Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i): Convert error logs to ErrorE func #2738

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(i): Convert error logs to ErrorE func #2738

merged 1 commit into from
Jun 18, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Jun 18, 2024

Relevant issue(s)

Resolves #2737

Description

This PR bumps corelog to v0.0.8 and converts error logs to ErrorE or ErrorContextE.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the area/logging Related to the logging/logger system label Jun 18, 2024
@nasdf nasdf added this to the DefraDB v0.12 milestone Jun 18, 2024
@nasdf nasdf self-assigned this Jun 18, 2024
@nasdf nasdf changed the title fix(i): Convert error logs to ErrorE fix(i): Convert error logs to ErrorE func Jun 18, 2024
@nasdf nasdf requested a review from a team June 18, 2024 18:57
AndrewSisley
AndrewSisley approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (3c0a14a) to head (caf30c2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2738      +/-   ##
===========================================
- Coverage    78.13%   78.09%   -0.04%     
===========================================
  Files          310      310              
  Lines        23188    23185       -3     
===========================================
- Hits         18117    18106      -11     
- Misses        3692     3697       +5     
- Partials      1379     1382       +3
Flag Coverage Δ
all-tests 78.09% <55.56%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/db/merge.go 74.45% <ø> (+0.33%) ⬆️
net/node.go 80.68% <100.00%> (ø)
net/peer.go 82.06% <33.33%> (-0.14%) ⬇️
net/server.go 80.22% <60.00%> (+1.10%) ⬆️

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0a14a...caf30c2. Read the comment docs.

@nasdf nasdf merged commit 9f50a73 into sourcenetwork:develop Jun 18, 2024
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@nasdf nasdf

Labels
area/logging Related to the logging/logger system
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging this pull request may close these issues.

Convert error logs to corelog.ErrorE
2 participants
@nasdf @AndrewSisley